Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emoji in print statements, because why not? #205

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

sleberknight
Copy link
Member

No description provided.

@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Jul 19, 2024
@sleberknight sleberknight added this to the 0.14.0 milestone Jul 19, 2024
@sleberknight sleberknight self-assigned this Jul 19, 2024
Change from using StdOut.capturedLines to capturedString.
The lines captured with the emoji results in weird things, for
example the number "4" preceding the checkmark emoji and
the "Wrote changelog" text. By changing to capturedString,
the wonkyness seems to go away, since the test now passes
when including the check emoji.
Copy link

@sleberknight sleberknight merged commit 85f5eb5 into main Jul 19, 2024
5 checks passed
@sleberknight sleberknight deleted the add-emoji-in-printlns branch July 19, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant