Sonar: Declare local variables with 'var' when the type is clear (#83)

kiwiproject · May 29, 2021 · 5d369d1 · 5d369d1
1 parent ecabe47
commit 5d369d1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/main/java/org/kiwiproject/retry/Retryer.java b/src/main/java/org/kiwiproject/retry/Retryer.java
@@ -95,7 +95,7 @@ public final class Retryer {
      */
     public <T> T call(Callable<T> callable) throws RetryException, InterruptedException {
         long startTimeNanos = System.nanoTime();
-        for (int attemptNumber = 1; ; attemptNumber++) {
+        for (var attemptNumber = 1; ; attemptNumber++) {
             var attempt = call(callable, startTimeNanos, attemptNumber);
 
             listeners.forEach(listener -> safeInvokeListener(listener, attempt));

diff --git a/src/main/java/org/kiwiproject/retry/RetryerBuilder.java b/src/main/java/org/kiwiproject/retry/RetryerBuilder.java
@@ -226,7 +226,7 @@ public boolean test(Attempt<?> attempt) {
             }
             try {
                 @SuppressWarnings("unchecked")
-                T result = (T) attempt.getResult();
+                var result = (T) attempt.getResult();
                 return delegate.test(result);
             } catch (ClassCastException e) {
                 return false;

diff --git a/src/main/java/org/kiwiproject/retry/WaitStrategies.java b/src/main/java/org/kiwiproject/retry/WaitStrategies.java
@@ -355,11 +355,11 @@ private long fib(long n) {
             if (n == 0L) return 0L;
             if (n == 1L) return 1L;
 
-            long prevPrev = 0L;
-            long prev = 1L;
-            long result = 0L;
+            var prevPrev = 0L;
+            var prev = 1L;
+            var result = 0L;
 
-            for (long i = 2L; i <= n; i++) {
+            for (var i = 2L; i <= n; i++) {
                 result = prev + prevPrev;
                 prevPrev = prev;
                 prev = result;
@@ -380,7 +380,7 @@ private static final class CompositeWaitStrategy implements WaitStrategy {
 
         @Override
         public long computeSleepTime(Attempt<?> failedAttempt) {
-            long waitTime = 0L;
+            var waitTime = 0L;
             for (WaitStrategy waitStrategy : waitStrategies) {
                 waitTime += waitStrategy.computeSleepTime(failedAttempt);
             }