Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review deprecated method in StopStrategies #12

Closed
sleberknight opened this issue Jan 5, 2021 · 0 comments · Fixed by #20
Closed

Review deprecated method in StopStrategies #12

sleberknight opened this issue Jan 5, 2021 · 0 comments · Fixed by #20
Assignees
@sleberknight
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Milestone
0.5.0

Comments

@sleberknight
Copy link
Member

sleberknight commented Jan 5, 2021 •
edited
Loading

StopStrategies#stopAfterDelay(long delayInMillis) was already deprecated by a previous author way back in 2015. Review this, and either remove the deprecated code, or remove the deprecation.
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Jan 5, 2021
@sleberknight sleberknight added this to the 0.5.0 milestone Jan 5, 2021
@sleberknight sleberknight self-assigned this Jan 5, 2021
@sleberknight sleberknight changed the title Review code that was already deprecated Review deprecated method in StopStrategies Jan 5, 2021
sleberknight added a commit that referenced this issue Jan 6, 2021
@sleberknight
Remove deprecated StopStrategies#stopAfterDelay(long millis)
b0d63b1 
This method was deprecated way back in 2015. There is no reason
whatsoever for us to continue including a deprecated method in a library
that we are now going to maintain.

Closes #12
@sleberknight sleberknight mentioned this issue Jan 6, 2021
Merged
chrisrohr pushed a commit that referenced this issue Jan 6, 2021
@sleberknight
Remove deprecated StopStrategies#stopAfterDelay(long millis) (#20)
6daa65b 
This method was deprecated way back in 2015. There is no reason
whatsoever for us to continue including a deprecated method in a library
that we are now going to maintain.

Closes #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Remove deprecated StopStrategies#stopAfterDelay(long millis) kiwiproject/retrying-again
1 participant
@sleberknight