Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split tests that really contain multiple tests #15

Closed
sleberknight opened this issue Jan 5, 2021 · 0 comments · Fixed by #19
Closed

Split tests that really contain multiple tests #15

sleberknight opened this issue Jan 5, 2021 · 0 comments · Fixed by #19
Assignees
@sleberknight
Labels
refactoring Code refactoring
Milestone
0.5.0

Comments

@sleberknight
Copy link
Member

sleberknight commented Jan 5, 2021 •
edited
Loading

Many tests are logically separate tests, and if the first one in the test method fails, then the subsequent (logical) tests are never executed until the first one is fixed, meaning you won't know if those also have problems until possibly much later...

I started doing this in #14 but realized it should be done as a separate commit, or commits...
@sleberknight sleberknight added the refactoring Code refactoring label Jan 5, 2021
@sleberknight sleberknight added this to the 0.5.0 milestone Jan 5, 2021
@sleberknight sleberknight self-assigned this Jan 5, 2021
@sleberknight sleberknight mentioned this issue Jan 6, 2021
Closed
sleberknight added a commit that referenced this issue Jan 6, 2021
@sleberknight
Split logical tests into separate test methods
49b9791 
* Finish splitting out logical tests that are combined in test methods
  into separate test methods in RetryerTest and RetryerBuilderTest
* There is a lot of repetitive RetryerException assertion code, which
  I will deal with later, maybe using an AssertJ-style fluent style

Closes #15
@sleberknight sleberknight mentioned this issue Jan 6, 2021
Merged
chrisrohr pushed a commit that referenced this issue Jan 6, 2021
@sleberknight
Split logical tests into separate test methods (#19)
079197a 
* Finish splitting out logical tests that are combined in test methods
  into separate test methods in RetryerTest and RetryerBuilderTest
* There is a lot of repetitive RetryerException assertion code, which
  I will deal with later, maybe using an AssertJ-style fluent style

Closes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
refactoring Code refactoring
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Split logical tests into separate test methods kiwiproject/retrying-again
1 participant
@sleberknight