Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup raw types wherever possible #23

Closed
sleberknight opened this issue Jan 6, 2021 · 1 comment · Fixed by #29
Closed

Cleanup raw types wherever possible #23

sleberknight opened this issue Jan 6, 2021 · 1 comment · Fixed by #29
Assignees
@sleberknight
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Milestone
0.5.0

Comments

@sleberknight
Copy link
Member

Where possible use generics, even if it means using <?> in some cases, for classes that are parameterized. This is now only the Attempt class, since the type parameters was removed from Retryer and RetryerBuilder.
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Jan 6, 2021
@sleberknight sleberknight added this to the 0.5.0 milestone Jan 6, 2021
@sleberknight sleberknight self-assigned this Jan 6, 2021
@sleberknight
Copy link
Member Author

Later, we can and should revisit whether there is a better long term solution because I hate using <?>...

sleberknight added a commit that referenced this issue Jan 7, 2021
@sleberknight
Replace raw usages of Attempt
c56fa31 
* Replace raw usages of Attempt with Attempt<?> which is not really
  ideal. Opened new discussion #28 to discuss a long term solution.

Closes #23
@sleberknight sleberknight mentioned this issue Jan 7, 2021
Merged
chrisrohr pushed a commit that referenced this issue Jan 7, 2021
@sleberknight
Replace raw usages of Attempt (#29)
f655a8c 
* Replace raw usages of Attempt with Attempt<?> which is not really
  ideal. Opened new discussion #28 to discuss a long term solution.

Closes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Replace raw usages of Attempt kiwiproject/retrying-again
1 participant
@sleberknight