Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Guava collection factories with JDK ones where possible #42

Closed
sleberknight opened this issue Jan 21, 2021 · 0 comments · Fixed by #47
Closed

Replace Guava collection factories with JDK ones where possible #42

sleberknight opened this issue Jan 21, 2021 · 0 comments · Fixed by #47
Assignees
@sleberknight
Labels
enhancement A request for change or improvement to an existing feature
Milestone
0.5.0

Comments

@sleberknight
Copy link
Member

Replace Guava Lists.newArrayList and Sets.newHashSet with JDK collection factories (List.of, Set.of) when possible (i.e. when the collection can be unmodifiable)
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Jan 21, 2021
@sleberknight sleberknight added this to the 0.5.0 milestone Jan 21, 2021
sleberknight added a commit that referenced this issue Jan 21, 2021
@sleberknight
Replace Guava collection factory methods with native JDK APIs
4bbd1ea 
* Replace Lists.newArrayList() with new ArrayList<>() in RetryerBuilder
* Replace Sets.newHashSet() w/new HashSet<>() in AttemptTimeLimitersTest
* Replace Lists.newArrayList(waitStrategies) to the more verbose
  new ArrayList<>(Arrays.asList(waitStrategies)) because of the null
  check below. For now just wanted to keep existing behavior as-is so
  this was one way using only native JDK API.

Closes #42
@sleberknight sleberknight mentioned this issue Jan 21, 2021
Merged
@sleberknight sleberknight self-assigned this Jan 22, 2021
chrisrohr pushed a commit that referenced this issue Jan 22, 2021
@sleberknight
Replace Guava collection factory methods with native JDK APIs (#47)
1b076f7 
* Replace Lists.newArrayList() with new ArrayList<>() in RetryerBuilder
* Replace Sets.newHashSet() w/new HashSet<>() in AttemptTimeLimitersTest
* Replace Lists.newArrayList(waitStrategies) to the more verbose
  new ArrayList<>(Arrays.asList(waitStrategies)) because of the null
  check below. For now just wanted to keep existing behavior as-is so
  this was one way using only native JDK API.

Closes #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Replace Guava collection factory methods with native JDK APIs kiwiproject/retrying-again
1 participant
@sleberknight