Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove get() method in Attempt #50

Closed
sleberknight opened this issue Jan 22, 2021 · 0 comments · Fixed by #51
Closed

Remove get() method in Attempt #50

sleberknight opened this issue Jan 22, 2021 · 0 comments · Fixed by #51
Assignees
@sleberknight
Labels
refactoring Code refactoring
Milestone
0.5.0

Comments

@sleberknight
Copy link
Member

Per #27 remove the generic get() method from Attempt, leaving getResult() which is explicit and parallels the getException() method.

If we were past 1.x this would be a breaking change, but since we're not, it doesn't.
@sleberknight sleberknight added the refactoring Code refactoring label Jan 22, 2021
@sleberknight sleberknight added this to the 0.5.0 milestone Jan 22, 2021
@sleberknight sleberknight self-assigned this Jan 22, 2021
@sleberknight sleberknight mentioned this issue Jan 22, 2021
Closed
sleberknight added a commit that referenced this issue Jan 22, 2021
@sleberknight
Remove redundant get() method from Attempt
51e278c 
* Remove get() and leave getResult()

Closes #50
@sleberknight sleberknight mentioned this issue Jan 22, 2021
Merged
chrisrohr pushed a commit that referenced this issue Jan 22, 2021
@sleberknight
Remove redundant get() method from Attempt (#51)
8482124 
* Remove get() and leave getResult()

Closes #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
refactoring Code refactoring
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Remove redundant get() method from Attempt kiwiproject/retrying-again
1 participant
@sleberknight