Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert assertions to use AssertJ #6

Closed
sleberknight opened this issue Dec 23, 2020 · 0 comments · Fixed by #16
Closed

Convert assertions to use AssertJ #6

sleberknight opened this issue Dec 23, 2020 · 0 comments · Fixed by #16
Assignees
@sleberknight
Labels
refactoring Code refactoring
Milestone
0.5.0

Comments

@sleberknight
Copy link
Member

No description provided.

@sleberknight sleberknight added the refactoring Code refactoring label Dec 23, 2020
@sleberknight sleberknight added this to the 0.5.0 milestone Dec 23, 2020
@sleberknight sleberknight self-assigned this Dec 23, 2020
sleberknight added a commit that referenced this issue Jan 5, 2021
@sleberknight
Convert native JUnit assertions to AssertJ
6ee53c3 
Other changes:
* Split a few tests apart that were really separate tests
* Replaced a few try/catch/fail in tests with AssertJ constructs
  like assertThatThrownBy and catchThrowable combined with KiwiAssertJ
  from kiwi-test (which I added as a test scope dependency
* Converted repetitive code in tests to use @ParameterizedTest instead
  so that the test code is the same, and the @XxxSource for the test
  describes the test data and expected results, which is the only real
  difference
* RetryerTest was somehow still formatted with 2-space indent, so I
  fixed that too

Closes #6
@sleberknight sleberknight mentioned this issue Jan 5, 2021
Merged
sleberknight added a commit that referenced this issue Jan 5, 2021
@sleberknight
Convert native JUnit assertions to AssertJ (#16)
5eab453 
Other changes:
* Split a few tests apart that were really separate tests
* Replaced a few try/catch/fail in tests with AssertJ constructs
  like assertThatThrownBy and catchThrowable combined with KiwiAssertJ
  from kiwi-test (which I added as a test scope dependency
* Converted repetitive code in tests to use @ParameterizedTest instead
  so that the test code is the same, and the @XxxSource for the test
  describes the test data and expected results, which is the only real
  difference
* RetryerTest was somehow still formatted with 2-space indent, so I
  fixed that too

Closes #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
refactoring Code refactoring
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Convert native JUnit assertions to AssertJ kiwiproject/retrying-again
1 participant
@sleberknight