Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusual behavior when using video play icon functionality #69

Open
zahari opened this issue Aug 7, 2019 · 1 comment
Open

Unusual behavior when using video play icon functionality #69

zahari opened this issue Aug 7, 2019 · 1 comment

Comments

@zahari
Copy link

zahari commented Aug 7, 2019

Description of problem

On the website video buttons on the bottom row events are not aligned properly.
https://imgur.com/a/dArJsgW

Version or commit hash (if applicable)

d1389af

Steps to Reproduce

  1. Open http://kiwitcms.org/
  2. Look at DOM component #seen-at
  3. Observe unusual behavior while playing the videos for each event

Actual results

  • play buttons are positioned in right upper corner (unusual location)
  • when you play a video you cannot toggle out of it using ESC
  • when you play a video you cannot see X close functionality while hovering to the upper right corner

Expected results

  • you should be able to see a close X sign when the video goes fullscreen
  • you should be able to toggle from fullscreen playback with ESC key
  • video play button is normally situated on in the center of the image
@atodorov
Copy link
Member

atodorov commented Aug 7, 2019

video play button is normally situated on in the center of the image

Two comments on this:

  1. Who says the center position is "normal" ? Which is the authoritative body on this design? You need some data to back up this claim, otherwise it is only your personal opinion on how things should look like.

  2. putting the play button in the center will hide some of the images. How much and to what extent we don't know before we have tried it and seen how it will look like. May turn out to be not that bad, may turn out to be worse.

The Esc and X functionality for closing the window is indeed something that is missing and is not related to the play button positioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants