Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Settings > Storage #3970

Closed
kelson42 opened this issue Aug 5, 2024 · 2 comments · Fixed by #3972
Closed

Revamp Settings > Storage #3970

kelson42 opened this issue Aug 5, 2024 · 2 comments · Fixed by #3972
Assignees
Milestone

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Aug 5, 2024

Here are the requested changes:

  • Stop using an overlay/dialog box, the radio button to choose between the multiple storages should be directly in the settings
  • It should be clearer (written?) what is total and empty space
  • The exact path used should be written. In can this is the storage chosen, then we know what it is as this is a settings stored in the configuration. But in case of a non-used storage, this is hypothetical as there is no settings, the value should come from the code. This last bullet point is important as we will move from the private to the public app directory... people with everything in the private app directory should keep their private app directory but new user should better use public app directory.
@kelson42
Copy link
Collaborator Author

kelson42 commented Aug 5, 2024

@MohitMaliDeveloper Please propose first a mockup so we can validate the design first.

@MohitMaliFtechiz
Copy link
Collaborator

@kelson42 For the UI part we will remove the storage Selection dialog from the settings and will show radio buttons for selecting the storage(if the SD card is available then it will show in the radio button, Otherwise a single radio button of internal storage will be show on the setting screen with proper total and empty space available in the storage). The storage path will be show on the settings screen in front of the selected storage, which will come from the code.

Dialog will remove Radio button will show like this
Screenshot_20240806-104446 Screenshot_20240806-104549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants