-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the dialog box to select the storage in settings. #3972
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3972 +/- ##
============================================
- Coverage 53.26% 53.03% -0.23%
+ Complexity 1418 1411 -7
============================================
Files 303 304 +1
Lines 11813 11888 +75
Branches 1573 1584 +11
============================================
+ Hits 6292 6305 +13
- Misses 4504 4553 +49
- Partials 1017 1030 +13 ☔ View full report in Codecov by Sentry. |
* Now, the storage selection (internal/external) is directly visible in the settings, allowing users to select storage without using a dialog box. * The total and available space for each storage option is displayed. * Additionally, the selected storage path is shown in the settings, so users know where the downloaded files will be saved.
89df628
to
1f0cdbe
Compare
@MohitMaliDeveloper This is pretty much what I had in mind, two things: |
* Now the storage path will show for non-selected storage as well. * Improved the KiwixSettingsFragmentTest.
@kelson42 I have made the changes as you requested and updated the PR description with the video for design reference. |
@MohitMaliFtechiz Thisnlooks perfect. Have you checked this displaynproperly in RTL laanguages like arabic? |
* Ensured that the storage path and title are displayed correctly in both LTR and RTL layouts.
@kelson42 Now it's displaying properly in RTL. |
Fixes #3970
XRecorder_07082024_172703.mp4