Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the dialog box to select the storage in settings. #3972

Merged
merged 7 commits into from
Aug 8, 2024
Merged

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Aug 6, 2024

Fixes #3970

  • Now, the storage selection (internal/external) is directly visible in the settings with new visual, allowing users to select storage without using a dialog box.
  • The total, used, and available space for each storage option is displayed.
  • Additionally, the selected storage path is shown in the settings, so users know where the downloaded files will be saved.
XRecorder_07082024_172703.mp4

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft August 6, 2024 11:01
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 78.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 53.03%. Comparing base (5a58800) to head (65297a7).

Files Patch % Lines
...g/kiwix/kiwixmobile/settings/KiwixPrefsFragment.kt 81.03% 1 Missing and 10 partials ⚠️
...bile/core/settings/StorageRadioButtonPreference.kt 75.67% 1 Missing and 8 partials ⚠️
...wix/kiwixmobile/core/settings/CorePrefsFragment.kt 66.66% 1 Missing ⚠️
...wix/kiwixmobile/core/settings/StorageCalculator.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3972      +/-   ##
============================================
- Coverage     53.26%   53.03%   -0.23%     
+ Complexity     1418     1411       -7     
============================================
  Files           303      304       +1     
  Lines         11813    11888      +75     
  Branches       1573     1584      +11     
============================================
+ Hits           6292     6305      +13     
- Misses         4504     4553      +49     
- Partials       1017     1030      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review August 6, 2024 13:47
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft August 6, 2024 13:48
* Now, the storage selection (internal/external) is directly visible in the settings, allowing users to select storage without using a dialog box.
* The total and available space for each storage option is displayed.
* Additionally, the selected storage path is shown in the settings, so users know where the downloaded files will be saved.
@kelson42
Copy link
Collaborator

kelson42 commented Aug 7, 2024

@MohitMaliDeveloper This is pretty much what I had in mind, two things:

  • Please always display the location, even if not selected.
  • Use this visual representation
    image

@MohitMaliFtechiz
Copy link
Collaborator Author

MohitMaliFtechiz commented Aug 7, 2024

@kelson42 I have made the changes as you requested and updated the PR description with the video for design reference.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review August 7, 2024 15:40
@kelson42
Copy link
Collaborator

kelson42 commented Aug 7, 2024

@MohitMaliFtechiz Thisnlooks perfect. Have you checked this displaynproperly in RTL laanguages like arabic?

* Ensured that the storage path and title are displayed correctly in both LTR and RTL layouts.
@MohitMaliFtechiz
Copy link
Collaborator Author

@MohitMaliFtechiz Thisnlooks perfect. Have you checked this displaynproperly in RTL laanguages like Arabic?

@kelson42 Now it's displaying properly in RTL.

Screenshot from 2024-08-08 11-03-50

@kelson42 kelson42 merged commit a6de67e into main Aug 8, 2024
10 checks passed
@kelson42 kelson42 deleted the Fixes#3970 branch August 8, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp Settings > Storage
3 participants