Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Send diagnostic report" function should open the user's email client #4005

Closed
Popolechien opened this issue Sep 23, 2024 · 3 comments · Fixed by #4042
Closed

"Send diagnostic report" function should open the user's email client #4005

Popolechien opened this issue Sep 23, 2024 · 3 comments · Fixed by #4042
Assignees
Milestone

Comments

@Popolechien
Copy link
Member

Popolechien commented Sep 23, 2024

In the Help tab, the Send diagnostic report only generates a diagnostic report, without an indication of the next steps.

On my phone (Nothing Phone, Android 14), clicking on Send details opens the Sharing tab, but this by default lists my friends on Whatsapp/Signal. Meanwhile, the Send feedback option does open the user's email client directly so this clearly is something that can be directly actioned by Kiwix.

@kelson42 kelson42 added this to the 3.12.0 milestone Sep 23, 2024
@kelson42 kelson42 self-assigned this Sep 23, 2024
@kelson42
Copy link
Collaborator

kelson42 commented Sep 23, 2024

I will assess this issue before implementation.

@kelson42
Copy link
Collaborator

kelson42 commented Oct 1, 2024

@MohitMaliFtechiz Hope this is clear to you to which email address it should be send. But OK to implement.

@kelson42 kelson42 removed their assignment Oct 1, 2024
@kelson42 kelson42 removed the question label Oct 1, 2024
@MohitMaliFtechiz
Copy link
Collaborator

@Popolechien, @kelson42 This is not directly doable to implement this. Since we are attaching a file in email with device logs, and currently we are using the ACTION_SEND which supports the attaching files in email(But it shows the other apps in the suggestion list, like it is showing currently). For opening directly user's email client we have to use the ACTION_SENDTO with data = "mailto: which is only handled by the email apps so it will open the email client of the user's device(But in this action, we can not attach the files see https://developer.android.com/guide/components/intents-common#ComposeEmail for more details).

As shown in the below video it is directly showing the email client, but there is no log file attached in the body.

screen-20241007-183648.mp4

An approach is to implement this, we can remove the file from the diagnostic report, and add the device logs in the email body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants