Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: "Send diagnostic report" function should open the user's email client. #4042

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #4005

  • Previously, other apps were appearing in the suggestions when sending the diagnostic report. We have improved our intent so that it now directly opens the user's email client to send the diagnostic report to us.
  • We cannot attach a file to the email when using the ACTION_SENDTO action in the intent. So we have removed the file from the email and attached the device logs in emailBody.
screen-20241007-183648.mp4

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 57.94%. Comparing base (9954193) to head (61dd97c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../org/kiwix/kiwixmobile/core/error/ErrorActivity.kt 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4042      +/-   ##
============================================
- Coverage     57.97%   57.94%   -0.04%     
+ Complexity     1505     1502       -3     
============================================
  Files           315      315              
  Lines         13071    13066       -5     
  Branches       1659     1660       +1     
============================================
- Hits           7578     7571       -7     
- Misses         4399     4406       +7     
+ Partials       1094     1089       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Collaborator

kelson42 commented Oct 21, 2024

This needs to be rebased and can you clarify to me to which email address this diagnostic is sent?

Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

core/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
… client.

* Previously, other apps were appearing in the suggestions when sending the diagnostic report. We have improved our intent so that it now directly opens the user's email client to send the diagnostic report to us.
* We cannot attach a file to the email when using the `ACTION_SENDTO` action in the intent. However, we must use this intent action because it is the only one handled exclusively by email apps. This ensures that only email apps appear in the suggestions.
@MohitMaliFtechiz
Copy link
Collaborator Author

This needs to be rebased and can you clarify to me to which email address this diagnostic is sent?

@kelson42 The diagnostic report will be sent to android-crash-feedback@kiwix.org email as it was previously sending.

@kelson42 kelson42 merged commit eaa28d6 into main Oct 24, 2024
21 of 22 checks passed
@kelson42 kelson42 deleted the Fixes#4005 branch October 24, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Send diagnostic report" function should open the user's email client
3 participants