Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set colour standards #411

Closed
siddharthks2010 opened this issue Feb 15, 2018 · 4 comments
Closed

set colour standards #411

siddharthks2010 opened this issue Feb 15, 2018 · 4 comments

Comments

@siddharthks2010
Copy link

All throughout the app, the color is black, but however, the check boxes and the OK button in the select language are of different colors (blue and green) which looks quite odd.

sss

I guess both should be black or at least of the same color, if not black.

@siddharthks2010
Copy link
Author

I would like to work on this.

@mhutti1
Copy link
Contributor

mhutti1 commented Feb 15, 2018

See kiwix/kiwix-xulrunner#259 I am not sure about the green. I think it might be a system UI thing. It might be a good idea to change it. Can you find any Android docs on it?

@siddharthks2010
Copy link
Author

I will check it out and let you know as soon as I get something.

@siddharthks2010
Copy link
Author

I found a solution to changing the color if the OK button to blue as well. the dialog box is basically an AlertDialog that takes the theme "Theme_AppCompat_Light_Dialog_Alert" in light mode and the theme "Theme_Holo_Dialog" in dark mode. So I just need to modify the theme to change the color of the button. I was thinking of matching the color of the ok button to the color of the checkbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants