Remove deprecate objects from LibraryNetworkEntitiy

[gouri-panda]

We deprecated the File object in LibraryNetworkEntitiy. Perhaps it's time to remove deprecated objects/methods.

kiwix-android/core/src/main/java/org/kiwix/kiwixmobile/core/entity/LibraryNetworkEntity.java

Lines 94 to 97 in 2ab7a55

	@Deprecated
	public File file;
	@Deprecated
	public String remoteUrl;

Originally posted by @gouri-panda in #3051 (comment)

Solution
We have to find alternative methods for this. We should refactor other classes' dependencies as well.

[soCallmeAdityaKumar]

I am interested in doing it can help me out.

[kelson42]

@gouri-panda Honestly I don’t understand this ticket. Who deprecated what exactly? For which reason? This File stuff seems deprecated but at the same time it should be replaced, this is contradictory? How to fix the problem?

We have here again a ticket which is not understable for anybody except the developers. An effort should be made to avoid this because nothing can be done as long as the ticket is not understandable.

[kelson42]

@MohitMaliDeveloper Would that be complicated to fix?

[gouri-panda]

@kelson42 Sorry for the late reply! I don't know why it has been deprecated. I think it's for good reasons Sean deprecated it. The purpose of this ticket is the replace with the good alternatives.

[rishujam]

Hey @gouri-panda can I work on this?

[kelson42]

@rishujam @gouri-panda @MohitMaliDeveloper What is exactly the plan here? If we don’t understand why this is deprecated, the I would do nothing. What woukd be an alternative and why it should be better?

[rishujam]

I guess it does not literally mean that the File object is deprecated instead we should stop using these attributes from LibraryNetworkEntitiy class. Also, remoteUrl attribute is not being used anywhere in the project. Is it right @gouri-panda ?

[kelson42]

@MohitMaliFtechiz Please clarify what has to be done, then it could be reassign to so eone else to do the real fix

[MohitMaliFtechiz]

@kelson42 , I have research about it an found below points.

• The file object is introduced in this commit of issue Travis-CI fails as we don't accept the terms of Google's licenses #279

• RemoteUrl is introduced in this commit of issue set colour standards #411

• We have deprecated these objects in this PR Macgills/2.5 downloader #1170 particularly in this commit

this PR fixed many tickets and i have checked many of them, I have not find any good reason to deprecated these objects on PR discussion as well as on ticket dicussion. But i have checked remoteUrl is unused here we can remove it.

[kelson42]

@MohitMaliFtechiz Please then domthe bit which is then necessar to close this ticket.