Macgills/2.5 downloader #1170
Merged
Macgills/2.5 downloader #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewHolder, BooksAdapter, LibraryFragment
kelson42
requested review from
mhutti1,
brijeshshah13 and
rashiq
and removed request for
mhutti1 and
brijeshshah13
…proved. Guava & apache commons removed
…ncelled outside application. Use transaction to mediate refresh rate of observables
…removal. Fix library stream breaking on error
…eakcanary to fix crash" This reverts commit 6e33ae2.
…and cannot be included. Remove multidex again
…or annotationProcesing. Raise MinSDK. Add timeouts to network requests.
…k old dbs deprecated
mhutti1
reviewed
May 17, 2019
There was a problem hiding this comment.
A few issues:
The library top bar is too high on my s8 so it almost clips the top
The download only over wifi option doesn't seem to do anything. It doesn't work anymore.
You can't pause downloads anymore. (What if a user is downloading a very large file)
Downloads don't seem to be in parallel and you can't see total progress (I guess this is fine)
Am I right in concluding that you now can't download large files onto fat32 formatted systems. If so then how are we communicating this?
…les, drop unused table
mhutti1
approved these changes
May 21, 2019
This was referenced May 27, 2019
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263 #597 #343 #340 #658 #668 #712 #703 #826 #830 #883 #889 #933 #907 #988 #975 #987 #990 #1007 #860
Changes: A new Downloader utilising Android's built-in DownloadManager was created, to facilitate this a total rewrite of ZimManageActivity, ZimFileSelectFragment, DownloadFragment and LibraryFragment was necessary. The new construction of these screens is that they all observe LiveData objects in the ZimManageViewModel which is a shared object that survives through configuration changes.
Internal subscriptions of the ViewModel keep the client data fresh and ready for binding, some updates can be triggered by pushing onto one of the ViewModel's inputs, named here as request* and implemented as reactive Processors.