Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve network status check #933

Closed
chris1b opened this issue Feb 4, 2019 · 1 comment · Fixed by #1168
Closed

Improve network status check #933

chris1b opened this issue Feb 4, 2019 · 1 comment · Fixed by #1168
Labels
enhancement
Milestone
2.5

Comments

@chris1b
Copy link
Contributor

chris1b commented Feb 4, 2019

NetworkUtils.java considers the state 'connecting' on mobile 'OK'

  1. The network state check should be more restrictive, e.g. a download operation should pause also if being in state 'connecting', as the respecting network login process may fail.
  2. The state info from the service is not checked against null and for 'connected' always.
  3. The respective tests have no annotation and fail if annotated as test.

Please review the proposal and comments in the fork branch
/chris1b/kiwix-android/tree/feature/improve_network_status_check

I will cleanup/simplify the proposed code upon your input.
@mhutti1
Copy link
Contributor

mhutti1 commented Feb 4, 2019

Could you please make a pull request so we can easily comment and keep track of changes?

@chris1b chris1b mentioned this issue Feb 5, 2019
Closed
@kelson42 kelson42 added this to the 2.5 milestone Apr 19, 2019
@chris1b chris1b mentioned this issue Apr 27, 2019
Merged
@macgills macgills mentioned this issue May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.5
3 participants
@kelson42 @mhutti1 @chris1b