Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes on clicking pause button for download in Landscape mode. #990

Closed
rohap97 opened this issue Feb 15, 2019 · 11 comments
Closed

App crashes on clicking pause button for download in Landscape mode. #990

rohap97 opened this issue Feb 15, 2019 · 11 comments
Labels
Milestone

Comments

@rohap97
Copy link

rohap97 commented Feb 15, 2019

Describe the bug

App crashes when we click pause button for download in Landscape mode.

Steps to reproduce the behavior:

  1. Start Downloading a .zim file
  2. Go to Downloading tab.
  3. Rotate the screen to Landscape mode.
  4. Click the pause button for ongoing download.
  5. App crashes

Environment

  • Version of Kiwix Android : 2.4 Build: 55
  • Device : Lenovo Vibe K5 Note
  • OS version : Android 6.0
@mhutti1 mhutti1 added the bug label Feb 17, 2019
@MisterAwesome23
Copy link
Contributor

It seems like downloadFragment.listView.invalidateViews();
doesn't know which orientation to move into. I'd like to work on this can anyone guide me? I am sort of a beginner to android.

@mhutti1
Copy link
Contributor

mhutti1 commented Feb 21, 2019

@MisterAwesome23 The general way to go about fixing something like this is to first reproduce it on a device you have. Then get a stacktrace for it. Using this work out where the code is incorrect and attempt to change it so you no longer crash.

@MisterAwesome23
Copy link
Contributor

What exactly is stack tracing. I performed the crash and noted the log cat for reason for crash that is from where I got the list view fragment function. Is there better ways to debug/stack trace or log cat is the right way.
I am pretty new to debugging too, any idea how to grap onto debugging quickly, like any course or resources?

@mhutti1
Copy link
Contributor

mhutti1 commented Feb 22, 2019

@MisterAwesome23 RE stacktracing yeah use you can use logcat. RE debugging its mostly something you just need to practise imo but there might be some good tutorials on Google.

@ShridharGoel
Copy link
Contributor

Can I take this up?

@abdulwd
Copy link
Contributor

abdulwd commented Mar 7, 2019

@ShridharGoel You can work on it. I think @MisterAwesome23 is not working on this.

@iadeelzafar
Copy link
Contributor

I tried to reproduce this today but i couldn't reproduce this.
@abdulwd @shridharghoel can you?

@ShridharGoel
Copy link
Contributor

Yes I'm able to reproduce it.

@iadeelzafar
Copy link
Contributor

@ShridharGoel Alright. Good Luck.

@ShridharGoel
Copy link
Contributor

@iadeelzafar Thanks.

@macgills
Copy link
Contributor

Fixed in #1170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants