Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No network connection #340

Closed
Albert221 opened this issue Jan 14, 2018 · 12 comments
Closed

No network connection #340

Albert221 opened this issue Jan 14, 2018 · 12 comments
Labels
Milestone

Comments

@Albert221
Copy link
Contributor

I see "No network connection" all the time on Online tab of Content Management although I'm connected to Internet all the time, no matter if it's WiFi or data. Logs give me this:

W/kiwixLibrary: Error loading books:Permission denied (missing INTERNET permission?)

And it looks like this:

image

@kelson42
Copy link
Collaborator

Seems similar to #263

@Albert221
Copy link
Contributor Author

The device is Xiaomi Redmi 4 Pro

@kelson42
Copy link
Collaborator

@julianharty @mhutti1 @divadsn I would like your feedback about that issue please. Does the fixes done since the opening (in particular #323 fixing) should let us consider this ticket to as "fixed"?

@kelson42 kelson42 added the bug label Jan 20, 2018
@mhutti1
Copy link
Contributor

mhutti1 commented Jan 20, 2018

It shouldn't do as imo it has no relation to the log item in this issue.

@divadsn
Copy link
Contributor

divadsn commented Jan 21, 2018

As far as I know for Xiaomi devices running MIUI, they can restrict access to the Internet, it's not reproducable for me as stock Android 6.0 and higher do not allow restricting such permissions yet.

@divadsn
Copy link
Contributor

divadsn commented Jan 21, 2018

Also another thing I suspect is missing storage permissions maybe, as those are requested on first time when the library view is opened by the user.

That's impossible, as Kiwix will close the library when permissions aren't granted.

@julianharty
Copy link
Contributor

I agree this seems to be a distinct issue from #263

@Albert221 are you compiling & building Kiwix Android yourself or is this problem happening in the released version? If you're working with the source code please could you run git status to see if something's accidentally affected any of the build files such as the gradle files or AndroidManifest.xml. If you're able to post the output from git status that might help us too.

@Albert221
Copy link
Contributor Author

Albert221 commented Jan 23, 2018 via email

@julianharty
Copy link
Contributor

@Albert221 running git diff will help confirm whether the file was touched (or any other files related to the config and permissions). So as a place to start the debugging please could you run that command.

It's also possible to extract the AndroidManifest.xml from the app's binary and check that & I'm pretty sure there'll be tools available both to run locally and online that'll check what permissions the binary has set. So you could try one of these tools/utilities to check the binary too.

BTW: I expect that they'll confirm the permissions are correctly set (to include the Internet permission) the reason I'm suggesting these 2 steps first is so we can discard possible causes. They're also both easy to do and low risk.

@divadsn
Copy link
Contributor

divadsn commented Jan 23, 2018

@Albert221 have you checked the firewall which is built-in MIUI?

@Albert221
Copy link
Contributor Author

@julianharty

PS E:\AndroidStudioProjects\kiwix-android> git diff upstream/master --cached
PS E:\AndroidStudioProjects\kiwix-android> git diff upstream/master
PS E:\AndroidStudioProjects\kiwix-android>

No changes on AndroidManifest.xml as well as anything other. upstream is this repo.

@divadsn yes, there were no permissions (not that it was denied) related to Internet connection and every existing permission was allowed. I checked for example Messenger and it had no Internet permission either, so that's not the cause of it.

@kelson42 kelson42 added this to the 2.5 milestone Apr 19, 2019
@macgills
Copy link
Contributor

Fixed in #1170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants