Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Use http instead of https - Increase read timeout - bump abi codes … #1204

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

macgills
Copy link
Contributor

…to remove shadowing complaint - increase version to 2.5.1

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #1204 into release will decrease coverage by 0.59%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             release    #1204     +/-   ##
============================================
- Coverage      35.94%   35.35%   -0.6%     
  Complexity         1        1             
============================================
  Files            128      128             
  Lines           5032     5032             
  Branches         584      585      +1     
============================================
- Hits            1809     1779     -30     
- Misses          3011     3041     +30     
  Partials         212      212
Impacted Files Coverage Δ Complexity Δ
...rg/kiwix/kiwixmobile/di/modules/NetworkModule.java 90.9% <66.66%> (-9.1%) 0 <0> (ø)
...java/org/kiwix/kiwixmobile/ZimContentProvider.java 18% <0%> (-12.8%) 0% <0%> (ø)
.../org/kiwix/kiwixmobile/utils/files/FileSearch.java 56.89% <0%> (-0.87%) 0% <0%> (ø)
...ava/org/kiwix/kiwixmobile/KiwixMobileActivity.java 30.21% <0%> (-0.1%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10c2e3...e680155. Read the comment docs.

@macgills macgills requested a review from mhutti1 June 18, 2019 15:26
@macgills macgills merged commit 7da84c0 into release Jun 19, 2019
@macgills macgills deleted the macgills/hotfix/use-http branch June 19, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants