Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1165 New external storage disappears on screen rotation #1380

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

macgills
Copy link
Contributor

Fixes #1165

Changes: Convert to kotlin remove custom storage choice

@macgills macgills requested a review from mhutti1 August 15, 2019 14:42
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@189e1b4). Click here to learn what that means.
The diff coverage is 65.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1380   +/-   ##
==========================================
  Coverage           ?   30.04%           
  Complexity         ?        1           
==========================================
  Files              ?      191           
  Lines              ?     7258           
  Branches           ?      824           
==========================================
  Hits               ?     2181           
  Misses             ?     4845           
  Partials           ?      232
Impacted Files Coverage Δ Complexity Δ
...mobile/zim_manager/library_view/LibraryFragment.kt 24.05% <0%> (ø) 0 <0> (?)
...ix/kiwixmobile/settings/KiwixSettingsActivity.java 64.11% <60%> (ø) 0 <0> (?)
...va/eu/mhutti1/utils/storage/StorageSelectDialog.kt 75% <75%> (ø) 0 <0> (?)
...mhutti1/utils/storage/StorageSelectArrayAdapter.kt 78.57% <78.57%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189e1b4...0785df2. Read the comment docs.

Copy link
Contributor

@mhutti1 mhutti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully agree with removing this feature but I agree we can go ahead.

@macgills
Copy link
Contributor Author

Thanks for the approval

@macgills macgills merged commit 786d168 into develop Aug 16, 2019
@macgills macgills deleted the feature/macgills/#1165-remove-custom-external branch August 16, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New external storage disappears on screen rotation
2 participants