Fixed: Nowdays CI frequently failing on API level 24, and 33. #3659
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3659 +/- ##
============================================
- Coverage 48.59% 48.58% -0.01%
Complexity 1090 1090
============================================
Files 285 285
Lines 10588 10588
Branches 1418 1418
============================================
- Hits 5145 5144 -1
- Misses 4599 4600 +1
Partials 844 844 ☔ View full report in Codecov by Sentry. |
|
So here is the main reason for test failure, The emulator does not have an active wifi connection that is why "Wifi connection" dialog is not displaying, These logs confirm this: See workflow: https://github.com/kiwix/kiwix-android/actions/runs/7461002166/job/20300232710?pr=3659 |
MohitMaliFtechiz
force-pushed
the
Fix#3627
branch
from
0f71746 to
be5153b
Compare
|
@gouri-panda This PR is ready for review. It fixes the CI which is often failing. |
|
@MohitMaliDeveloper It failed!!! Please see my comment on the #android chat and reduce the level of verbosity to keep only the essential |
MohitMaliFtechiz
force-pushed
the
Fix#3627
branch
from
b304788 to
bc7055b
Compare
* Addressed an issue with the `SaveSearchToRecentsTest` test, which occasionally failed. The primary cause of this was the recent modification to save the `RecentSearch` on a background thread using `coroutines`. In some cases, the test was validating the output before the coroutine completed its execution. Consequently, we have adjusted our test case to properly wait for the coroutine to finish its work before validating the output.
* Improved the permission. * Enabled wifi programmatically in emulator. * Improved test case for showing "Wifi connection dialog".
MohitMaliFtechiz
force-pushed
the
Fix#3627
branch
from
bc7055b to
adeabcf
Compare
|
@kelson42 I have reduced the verbosity level and now it is showing the essential logs, and now CI has been passed three times in a row without any error. |
Fixes #3627
SaveSearchToRecentsTesttest, which occasionally failed. The primary cause of this was the recent modification to save theRecentSearchon a background thread usingcoroutines. In some cases, the test validates the output before the coroutine completes its execution. Consequently, we have adjusted our test case to properly wait for the coroutine to finish its work before validating the output.ZimHostFragmenttest on API level 33 we have enabled the wifi programmatically on the emulator since it is by default not enabled on the emulator of API level 33.