Fixed: Low contrast issues reported by the playstore.
#3823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed the background color of `ErrorActivity` and checkbox to resolve the issue. * Added the background color in `IntroFragment` for resolving the issue, it is exact same design as previous. * Changed the tint color of `ic_feedback_orange_24dp` image to resolve the low contrast issue. * Changed the height of item_language item to wrap content instead of a fix height which prevent the expansion of layout if there is more content.
…became short due to our change because we have changed the height to `wrap_content`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3823 +/- ##
=========================================
Coverage 53.24% 53.24%
Complexity 1314 1314
=========================================
Files 292 292
Lines 11060 11060
Branches 1471 1471
=========================================
Hits 5889 5889
Misses 4195 4195
Partials 976 976 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3813
ErrorActivityand the checkbox to resolve the issue.IntroFragmentto resolve the issue, it is the same design as the previous one.ic_feedback_orange_24dpimage to resolve the low contrast issue.item_languageitem to wrap content instead of a fixed height which prevents the expansion of the layout if there is more content.Apart from these issues, other
Low contrastissues are just because they are behind something. For example, see the below screens.