-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated Notes to room database. #3863
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3863 +/- ##
============================================
- Coverage 53.94% 53.87% -0.07%
Complexity 1383 1383
============================================
Files 298 300 +2
Lines 11308 11361 +53
Branches 1495 1494 -1
============================================
+ Hits 6100 6121 +21
- Misses 4222 4252 +30
- Partials 986 988 +2 ☔ View full report in Codecov by Sentry. |
* Created NotesRoomDao, and NotesRoomEntity for saving the data in room database. * Refactored the code for saving the notes in room database.
…ario for notes. * Refactored the code for a better naming convention.
* We have refactored our code to use PageDao for managing data related to Bookmarks, Notes, and History. With the ability to return Flowable from the Room database, the BasePageDao interface has become unnecessary. Consequently, we have removed BasePageDao and streamlined our code to use PageDao, providing a unified approach for these functionalities. This change reduces code complexity and enhances readability, making the codebase easier to understand and maintain.
Fixes #3113
objectbox
.objectbox
toroom
. This will ensure that the previously saved notes will be shown to the user.NoteRoomDaoTest
, andKiwixRoomDatabaseTest
to test that it can save the different types of data.