Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/download fragment crash fix #3953

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

CalebKL
Copy link
Contributor

@CalebKL CalebKL commented Jul 23, 2024

Currently WIP
Fixes #3949

@CalebKL CalebKL marked this pull request as ready for review July 24, 2024 17:36
@kelson42 kelson42 force-pushed the task/download-fragment-crash-fix branch from ee365c6 to 4d83534 Compare July 25, 2024 05:49
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CalebKL Thanks 🎉 🎉

@MohitMaliFtechiz
Copy link
Collaborator

@CalebKL Can you please resolve the conflicts.

* Updated `setUpUncaughtErrorHandlerForOnlineLibrary` to handle `RxJavaPlugin` errors.
@MohitMaliFtechiz MohitMaliFtechiz force-pushed the task/download-fragment-crash-fix branch from 3fe8243 to f29634e Compare July 26, 2024 07:48
@MohitMaliFtechiz
Copy link
Collaborator

@kelson42 LGTM.

@kelson42 kelson42 merged commit 71d8a18 into kiwix:main Jul 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash loading the Download Fragment page
4 participants