Fixed: Online library cannot be retrieved in the Play Store variant. #3994
Conversation
* The issue arose after upgrading the Gradle version of our project (which introduced Android 14). The new Gradle version includes an updated minify tool that excludes SimpleXML attributes from the code. As a result, this error occurred. To resolve this, we added specific rules to the ProGuard file to ensure these attributes are retained in the release variant.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3994 +/- ##
============================================
+ Coverage 57.61% 57.94% +0.32%
- Complexity 1594 1603 +9
============================================
Files 312 314 +2
Lines 12984 13092 +108
Branches 1651 1663 +12
============================================
+ Hits 7481 7586 +105
+ Misses 4409 4399 -10
- Partials 1094 1107 +13 ☔ View full report in Codecov by Sentry. |
…plication to prevent this type of error from happening in the future.
…may show a complete pause message, such as 'Pause: Waiting for Retry,' which previously caused the test case to fail. The test case has been updated to accommodate this behavior.
… forceEnableAppTracing` error in UI test cases.
* Refactored the viewModel code to show the downloading updates, e.g. content is fetching, downloading the online content, etc.
…rary. * Also, disabled the refresh layout so avoid unnecessary calls when a request is already in progress.
…idth. * Since the online library file is 19MB large and on slow bandwidth devices it takes more time to fetch that file. Our current read timeout is 60 seconds which is not enough for reading this file on slow bandwidth devices. So we have increased it to 180 seconds.
…rogress. * Added a head request to get the library length and showing the progress on behalf of that length. * Improved the library loading process: previously, fetching the online library involved making two requests, which not only took more time to get a response from the server but also used twice the bandwidth. To address this, we have refactored our code to ensure that only one request is made at a time. * Upgraded the retrofit, and interceptor dependencies to latest version.
|
@MohitMaliDeveloper From a user perspective this looks really good, here a few points:
|
@kelson42 Yes, the sync does not happen on mobile data if the user does not accepted it.
@kelson42 It was happening, but I have placed a fix for it in this PR.
Yes, we have this scenario and it is working fine. I have tested it.
yes, the sync works in these scenarios.
@kelson42 I have made the changes as per your request.
Yes. the unit coverage was failing due to our changes. I have placed a fix for those test failures. |
…andwidth it cancel the previous ongoing request after 1 minute and retry again which increased the library load time.
|
@MohitMaliFtechiz wenn no wifi is available the download process should not start at all! |
@kelson42 The downloading/sync process only starts on the mobile network when the user confirms to sync/download via the mobile network. Downloading/Sync will not start when no wifi is available and the user does not agree to download/sync content via the mobile network. |
* Hiding the "No internet connection" text when user turn on the internet and previous this text is showing.
|
@MohitMaliDeveloper Thank you. I will merge this PR and please release in testflight. |
|
@kelson42 The application has been released in internal testing: https://github.com/kiwix/kiwix-android/actions/runs/10938877209/job/30367933099. |
Fixes #3991
SimpleXMLattributes from the code. As a result, this error occurred. To resolve this, we added specific rules to the ProGuard file to ensure these attributes are retained in the release variant.tracing:1.0.0. It is mentioned in the official github reposcreen-20240918-163719.mp4
Any suggestions/improvements are welcome for the UI to show the progress.