Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the "Send feedback" option from Help tab. #4013

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #4004

  • Removed the "Send feedback" option from the Help tab.
  • Removed all code related to this feature e.g. icons, strings, etc.
  • Refactored the HelpFragmentTest.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.79%. Comparing base (1a0cb84) to head (6b12e44).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4013      +/-   ##
============================================
- Coverage     57.98%   57.79%   -0.20%     
+ Complexity     1595     1587       -8     
============================================
  Files           314      314              
  Lines         13051    13035      -16     
  Branches       1657     1656       -1     
============================================
- Hits           7568     7533      -35     
- Misses         4375     4395      +20     
+ Partials       1108     1107       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Collaborator

kelson42 commented Oct 1, 2024

@MohitMaliFtechiz CI still unstable!

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft October 2, 2024 07:11
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review October 5, 2024 16:21
* Removed the all code related to this feature e.g. icon, strings, etc.
* Refactored the HelpFragmentTest.
@kelson42 kelson42 merged commit fc1b8dd into main Oct 6, 2024
22 checks passed
@kelson42 kelson42 deleted the Fixes#4004 branch October 6, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Send feedback" option from Help tab
3 participants