Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Not able to open a ZIM file from Samsung's file explorer. #4022

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Oct 8, 2024

Fixes #4002

  • Created a custom intent filter for Samsung's "My Files" app to handle all MIME types, allowing ZIM files to be opened directly from this file manager.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft October 8, 2024 13:17
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.01%. Comparing base (7400c26) to head (0eb618c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4022      +/-   ##
============================================
- Coverage     58.04%   58.01%   -0.04%     
+ Complexity     1517     1514       -3     
============================================
  Files           315      315              
  Lines         13125    13125              
  Branches       1671     1671              
============================================
- Hits           7619     7614       -5     
+ Misses         4412     4406       -6     
- Partials       1094     1105      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Collaborator

Please split the part about handling of files which are not proper ZIM files in a dedicated PR. Explain clearly what is the behaviour.

AFAIK this is not that easy because you can not always do it as you need first to move/copy the fikes to app directory first. When error, you should rollback this.

* Created a custom intent filter for Samsung's "My Files" app to handle all MIME types, allowing ZIM files to be opened directly from this file manager.
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review October 31, 2024 10:26
@kelson42 kelson42 merged commit ab3d8ff into main Oct 31, 2024
22 checks passed
@kelson42 kelson42 deleted the Fixes#4002 branch October 31, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to open a ZIM file from Samsung's "My Files" file explorer
3 participants