Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduced the Fetch Library for Downloading ZIM files. #4143

Merged
merged 15 commits into from
Dec 25, 2024

Fixed: The ZIM file was not opening when clicking on the download not…

a48f904
Select commit
Loading
Failed to load commit list.
Merged

Reintroduced the Fetch Library for Downloading ZIM files. #4143

Fixed: The ZIM file was not opening when clicking on the download not…
a48f904
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 24, 2024 in 0s

56.77% (-0.96%) compared to 4b8fe6d

View this Pull Request on Codecov

56.77% (-0.96%) compared to 4b8fe6d

Details

Codecov Report

Attention: Patch coverage is 58.06452% with 156 lines in your changes missing coverage. Please review.

Project coverage is 56.77%. Comparing base (4b8fe6d) to head (a48f904).

Files with missing lines Patch % Lines
...wnloader/downloadManager/DownloadMonitorService.kt 27.15% 99 Missing and 11 partials ⚠️
...ownloadManager/FetchDownloadNotificationManager.kt 77.27% 15 Missing and 5 partials ⚠️
...g/kiwix/kiwixmobile/core/data/KiwixRoomDatabase.kt 14.28% 18 Missing ⚠️
...wnloader/downloadManager/DownloadManagerMonitor.kt 79.16% 4 Missing and 1 partial ⚠️
...loader/downloadManager/DownloadManagerRequester.kt 83.33% 1 Missing and 1 partial ⚠️
...rg/kiwix/kiwixmobile/core/main/CoreMainActivity.kt 94.11% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #4143      +/-   ##
============================================
- Coverage     57.73%   56.77%   -0.96%     
- Complexity     1496     1516      +20     
============================================
  Files           313      312       -1     
  Lines         13324    13285      -39     
  Branches       1707     1644      -63     
============================================
- Hits           7692     7542     -150     
- Misses         4507     4612     +105     
- Partials       1125     1131       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov