#4236 Improved download notification strings replacing default Fetch #4241
Conversation
|
@amanna13 The PR is ready for review? |
Yes ! |
| @@ -402,4 +402,9 @@ | |||
| <string name="donation_dialog_title">Donate Today</string> | |||
| <string name="donation_dialog_description">%s needs your help.</string> | |||
| <string name="make_donation">Make a donation</string> | |||
| <string name="fetch_notification_download_complete">Complete</string> | |||
There was a problem hiding this comment.
@amanna13 We should give our name to these strings instead of fetch, and it could lead to unexpected behavior when accessing it at runtime. See in the below image we are using this string, and the R class we have imported in this class(DownloadMonitorService) from the fetch so this string will not take ours. So to avoid confusion we should rename it. Additionally, there are already some strings available e.g. Complete, Paused we should use the existing ones.
| else -> super.getSubtitleText(context, downloadNotification) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
After renaming the string name, please use our string in the getCancelNotification method of the FetchNotificationManager class so that it will use our text instead of fetch.
Fixes #4236
📌 Summary
Fetchlibrary strings with our own string resources to handle translation in other languages.