Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated the ErrorActivity to jetpack. #4253

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes#4249

  • Added the jetpack compose libraries in the project.
  • Created ErrorActivityScreen.kt class for handing the compose UI separately to maintain the separate concern.
  • Created ImageBitmapExtension.kt class for loading the image from bitmap folder.
  • Created ComposeButton.kt to maintain our default style button. We will use this ComposeButton everywhere where needed.

* Added the jetpack compose libraries in project.
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft March 1, 2025 13:33
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 164 lines in your changes missing coverage. Please review.

Project coverage is 57.36%. Comparing base (86f3852) to head (a02f2c9).

Files with missing lines Patch % Lines
...iwix/kiwixmobile/core/error/ErrorActivityScreen.kt 0.00% 44 Missing ⚠️
.../org/kiwix/kiwixmobile/core/error/ErrorActivity.kt 0.00% 43 Missing ⚠️
.../org/kiwix/kiwixmobile/core/utils/ComposeDimens.kt 0.00% 21 Missing ⚠️
...wix/kiwixmobile/core/composeviews/CrashCheckBox.kt 0.00% 19 Missing ⚠️
...wix/kiwixmobile/core/composeviews/ComposeButton.kt 0.00% 18 Missing ⚠️
...iwixmobile/core/extensions/ImageBitmapExtension.kt 0.00% 10 Missing ⚠️
...kiwixmobile/core/error/DiagnosticReportActivity.kt 0.00% 9 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4253      +/-   ##
============================================
- Coverage     57.50%   57.36%   -0.14%     
- Complexity     1589     1607      +18     
============================================
  Files           316      321       +5     
  Lines         14071    14197     +126     
  Branches       1745     1754       +9     
============================================
+ Hits           8091     8144      +53     
- Misses         4791     4851      +60     
- Partials       1189     1202      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… the values everwhere in code for better maintainability and consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants