Refactor manageExternalLaunchAndRestoringViewState #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename to loadZimFile because manageExternalLaunchAndRestoringViewState is a very confusing name - remove unnecessary logs and added comments instead - reduced nesting
|
@mhutti1 can you make sense of why exactly the build is failing? |
|
The random failing of travis build was discussed in #518. |
|
Gotcha @RohanBh. Though I restarted yesterday as well and got the same error; oh well let's see if it builds now! |
|
It's still failing |
|
@rashiq Do not worry about the build. It will get resolved in the upcoming Android Plugin version. |
|
It has passed now! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
|
This method still exists in the now renamed MainActivity, I would say it would be for the best to just redo the work as opposed to try and update this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is a very confusing name
This does not add any new functionality. It's just reducing complexity.