-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
72 update custom apps to be compatible with new launch sequence #73
72 update custom apps to be compatible with new launch sequence #73
Conversation
BPerlakiH
commented
Oct 11, 2024
- Update the common story board for custom apps.
- Update their info.json data, to include the welcomeLogo width and height.
- Update the README
The DWDS app also needs the loading text localised (DE):
|
This is good to go, in cooperation with kiwix/kiwix-apple#1008 gives the desired outcome for custom apps. |
…new-launch-sequence
@BPerlakiH Image width and height should be retrieved from the image file itself. This is fully redondant and source of error to have to specify it in the json. |
@kelson42 Yes, you are right. I have updated it so we get the size during runtime here: kiwix/kiwix-apple#1019 |