Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

72 update custom apps to be compatible with new launch sequence #73

Merged

Conversation

BPerlakiH
Copy link
Collaborator

  • Update the common story board for custom apps.
  • Update their info.json data, to include the welcomeLogo width and height.
  • Update the README

@BPerlakiH BPerlakiH added the enhancement New feature or request label Oct 11, 2024
@BPerlakiH BPerlakiH linked an issue Oct 11, 2024 that may be closed by this pull request
@BPerlakiH
Copy link
Collaborator Author

The DWDS app also needs the loading text localised (DE):

"welcome.loading.data.text" = "Loading Data...";

@BPerlakiH
Copy link
Collaborator Author

This is good to go, in cooperation with kiwix/kiwix-apple#1008 gives the desired outcome for custom apps.

@kelson42 kelson42 marked this pull request as ready for review October 18, 2024 09:21
@kelson42
Copy link
Contributor

@BPerlakiH Image width and height should be retrieved from the image file itself. This is fully redondant and source of error to have to specify it in the json.

@BPerlakiH
Copy link
Collaborator Author

@BPerlakiH Image width and height should be retrieved from the image file itself. This is fully redondant and source of error to have to specify it in the json.

@kelson42 Yes, you are right. I have updated it so we get the size during runtime here: kiwix/kiwix-apple#1019

@kelson42 kelson42 merged commit e7c12c2 into main Nov 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update custom apps to be compatible with new Launch sequence
2 participants