Systematic crash at start after update to 3.3

[kelson42]

After updating from 3.1 (App store version) to Testflight 3.3 on my macOS 12.6.6, the app just crash at launch every time.

[kelson42]

@BPerlakiH How would look ike the procedure to share all my local Kiwix config so you can test and reproduce the bug?

[BPerlakiH]

I am not sure, it might be down to the macOS version, but might as well be related to the other crash issue.
Unfortunately TestFlight is not really helpful, and not providing at the moment any details of crashes, or even installs at the moment (according to the "help buble" on developer.appple.com it can take up to 72 hours things to appear.
At this stage, I would recommend to retest this once we have this PR merged.

[BPerlakiH]

I've just started the Testflight process for the latest main branch (as the above PR was merged).
Once available, it should be re-tested on a clean environment, which can be achieved the following way:

• Open Applications -> Move Kiwix to Trash
• Empty Trash
• from the command line run: rm -rf ~/Library/Containers/self.Kiwix

[kelson42]

@BPerlakiH Stll crashing with testflight version of last night

[BPerlakiH]

I have found some main thread issues while testing my other PR for custom apps. So I think it will be worth to re-test it with this merged:
#688

[BPerlakiH]

I managed to re-create this one, it seems to be related to the largest file:
"canadianprepper_en_all_2023-11.zim"
it was downloading on my side for quite some time, so I am not sure if it's not corrupted in some way,

shasum -a 256 canadianprepper_en_all_2023-11.zim 
d1f3d64db5690f30333f3d7bd7b602a7f2cf27eb08d4f219345537af1546dafd  canadianprepper_en_all_2023-11.zim

nevertheless, it causes the same kind of crash.
The exception thrown by libzim (9.1) in ZimFileService:

+ (ZimFileMetaData *)getMetaDataWithFileURL:(NSURL *)url {
    ZimFileMetaData *metaData = nil;
    [url startAccessingSecurityScopedResource];
    try {
        kiwix::Book book = kiwix::Book();
        zim::Archive archive = zim::Archive([url fileSystemRepresentation]); // <---- crash is here
        book.update(archive);
        metaData = [[ZimFileMetaData alloc] initWithBook: &book];
    } catch (std::exception e) { }
    [url stopAccessingSecurityScopedResource];
    return metaData;
}

// Thread 1: Swift runtime failure: unhandled C++ / Objective-C exception

cannot be caught, and crashes the application.

It might be out of memory / disk error as well, as the file is quite large.
I will look into the C++ source code as well. At the moment it seems that there's not much more the objective-c swift code can do about this, it's already in try / catch.

[BPerlakiH]

Did found some further details, seems like an allocation error. Issue opened for LibZIM:
openzim/libzim#866

[kelson42]

Root cause of this behaviour is openzim/libzim#866. Keeping this ticket open for tracking.

[kelson42]

@BPerlakiH Can you please check if it works now and close if fixed?

[BPerlakiH]

@kelson42 I am happy to close this, it seems to be working as expected.