Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom apps ZIM migration #688

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Conversation

BPerlakiH
Copy link
Collaborator

@BPerlakiH BPerlakiH commented Mar 9, 2024

Fix for #601 - Migrating bookmarks for custom app.

There were a couple of thing to do:

  • make sure we migrate the bookmarks
  • migrate the tabs, which have "interactive data" - a kind of snapshot of the tab for webView, in a form of Data, which is now migrating at the point of opening the URL from that data
  • make sure we delete the old file reference in the DB - as currently we were displaying a list of local ZIM files in the menu, (up to 5). For custom apps it should really be only 1 item, so we make sure we remove the reference to the old ZIM file.

@kelson42
Copy link
Contributor

kelson42 commented Mar 9, 2024

@BPerlakiH Can you please fix the codefactor?

@kelson42
Copy link
Contributor

@BPerlakiH Ready to review?

@BPerlakiH
Copy link
Collaborator Author

There's one more thing need to be fixed here, which is the "interactive data" saved together with the state of each tab.
Will update the PR soon.

@BPerlakiH BPerlakiH changed the title Custom apps bookmark migration Custom apps ZIM migration Mar 11, 2024
@BPerlakiH
Copy link
Collaborator Author

@kelson42 @rgaudin it is ready for review.

rgaudin
rgaudin previously approved these changes Mar 11, 2024
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say much

SwiftUI/Model/ZimMigration.swift Outdated Show resolved Hide resolved
@kelson42 kelson42 merged commit 032a86c into main Mar 12, 2024
4 checks passed
@kelson42 kelson42 deleted the 601-custom-apps-bookmark-migration branch March 12, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants