-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logo of Kiwix should not be inverted in dark mode #934
Comments
@kelson42 It is not reproducible on iOS 17 (neither on the iPhone nor on the iPad), and works as expected on macOS as well. |
Postponing then |
@BPerlakiH Can you please handle that one next? |
@kelson42 from your screenshot, it looks like we are doing things properly: our logo being a black shape, it is inverted to white on dark background – the background being provided by the system. On your screenshot, you see that there are two kinds of icons:
All those background-less ones have probably not updated their app to support this new iOS18 feature (at the time of the screenshot it was a month before the release) and I suppose most will do in the near future (if not already). Deciding to go with a background-providing icon is an important design decision that should de discussed first IMO. With iOS18, we have this new feature but we (can) have control over it I suggest we (@siemsie) read the documentation about what is recommended and what is possible and then we discuss how this gets implemented |
Also please note that we are implementing the reversed logo look for the splash/launch/loading screens here: #976 So I suppose for consistency reasons, we should either allow to reverse the logo colours everywhere (app icon, launch screen etc.), or nowhere. |
See, this is the only one inverted!
I would like to have the same logo, so black kiwix on white background, so stay like the "Proton VPN" logo.
The text was updated successfully, but these errors were encountered: