Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo of Kiwix should not be inverted in dark mode #934

Open
kelson42 opened this issue Aug 17, 2024 · 5 comments
Open

Logo of Kiwix should not be inverted in dark mode #934

kelson42 opened this issue Aug 17, 2024 · 5 comments
Assignees
Milestone

Comments

@kelson42
Copy link
Contributor

kelson42 commented Aug 17, 2024

See, this is the only one inverted!
image

I would like to have the same logo, so black kiwix on white background, so stay like the "Proton VPN" logo.

@kelson42 kelson42 added the bug label Aug 17, 2024
@kelson42 kelson42 added this to the 3.5.0 milestone Aug 17, 2024
@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Aug 18, 2024

@kelson42 It is not reproducible on iOS 17 (neither on the iPhone nor on the iPad), and works as expected on macOS as well.
It seems to me that this is not a bug, but a new iOS 18 feature:
https://www.apple.com/newsroom/2024/06/ios-18-makes-iphone-more-personal-capable-and-intelligent-than-ever/

@kelson42
Copy link
Contributor Author

Postponing then

@kelson42 kelson42 modified the milestones: 3.5.0, 3.6.0 Aug 18, 2024
@kelson42 kelson42 added the iOS label Aug 18, 2024
@kelson42 kelson42 modified the milestones: 3.6.0, 3.5.2 Sep 6, 2024
@kelson42
Copy link
Contributor Author

@BPerlakiH Can you please handle that one next?

@rgaudin
Copy link
Member

rgaudin commented Sep 20, 2024

@kelson42 from your screenshot, it looks like we are doing things properly: our logo being a black shape, it is inverted to white on dark background – the background being provided by the system.

On your screenshot, you see that there are two kinds of icons:

  • background providing ones: Github, Uptime robot, Calc, etc (I count 12)
  • Background-less ones: All the rest including Kiwix, Stripe, etc (I count 18).

All those background-less ones have probably not updated their app to support this new iOS18 feature (at the time of the screenshot it was a month before the release) and I suppose most will do in the near future (if not already).

Deciding to go with a background-providing icon is an important design decision that should de discussed first IMO.

With iOS18, we have this new feature but we (can) have control over it

Screenshot 2024-09-20 at 09 58 52

I suggest we (@siemsie) read the documentation about what is recommended and what is possible and then we discuss how this gets implemented

@BPerlakiH
Copy link
Collaborator

Also please note that we are implementing the reversed logo look for the splash/launch/loading screens here: #976

So I suppose for consistency reasons, we should either allow to reverse the logo colours everywhere (app icon, launch screen etc.), or nowhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants