975 improve launch sequence

[BPerlakiH]

Fixes: #975

In combination with the library loading improvements gives a way better UX:

iphone_sim_loading_fix.mov

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 61.34454% with 46 lines in your changes missing coverage. Please review.

Project coverage is 38.09%. Comparing base (c25cbff) to head (572ea2e).

Files with missing lines	Patch %	Lines
Views/BuildingBlocks/LoadingView.swift	61.76%	13 Missing ⚠️
App/SplitViewController.swift	15.38%	11 Missing ⚠️
Views/Welcome.swift	73.17%	11 Missing ⚠️
App/CompactViewController.swift	55.55%	8 Missing ⚠️
Views/Library/ZimFilesCategories.swift	0.00%	2 Missing ⚠️
Views/Library/ZimFilesNew.swift	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   40.00%   38.09%   -1.91%     
==========================================
  Files         114      114              
  Lines        6471     6525      +54     
==========================================
- Hits         2589     2486     -103     
- Misses       3882     4039     +157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rgaudin]

Please provide more details about what this does.
AFAIU, we know have a spashscreen with centered kiwix-logo in lieu of a blank screen when starting the app.
I'm not sure what happens during this time but on my very old an slow iphone, it's visible but not noticeable (compared to other apps).

[kelson42]

My remarks:

• Please make the visual 50% bigger
• Make the splash screen dark-mode compatible (with default OS colorsets)
• @rgaudin Please share the link to the official visuals for both dark and light modse
• The logo should be displayed the whole time at the exact same place, and "Loadding... " should be displayed in place of the buttons as long as they are not available.

[BPerlakiH]

Please see the updated sequences on all type of devices, we have the combination of portrait / landscape and light / dark modes:

---

IPHONE

iphone_dark.mov

iphone_light.mov

---

IPAD

ipad_light_land.mov

ipad_dark_land.mov

ipad_dark_port.mov

ipad_light_port.mov

---

MAC

mac_os_light.mov

mac_os_dark.mov

[BPerlakiH]

The logo should be displayed the whole time at the exact same place, and "Loadding... " should be displayed in place of the buttons as long as they are not available.

This is not fully possible on iPad landscape mode:

We have a slight movement of the logo from the splash/landing screen to the loading view on iPad, due to the fact that the welcome screen is shifted by the side navigation panel. Here is a comparison of the "welcome screen" with collapsed / expanded navigation bar:

[BPerlakiH]

Note: on macOS the launch/splash screen is not supported, so we only have the loading sequence next to the side navigation panel.

[BPerlakiH]

Moved it to draft, please do not merge yet, as the custom app side of this needs to be solved first!

[BPerlakiH]

Looks OK now, I've tested with the DWDS app.

[kelson42]

I guess we need real logo now.

[BPerlakiH]

macOS:

macOS_noLib.mov

[BPerlakiH]

I agree, will tweak the UI.
Also on the same note, things that bothers you (and me), I separated one of those into a new issue, around the naming (not just the button), please see: #990

[kelson42]

@BPerlakiH Agree, after thinking "twice" about it, please remove the sidebar from thensplash screen. That way is clearer.

[BPerlakiH]

In accordance to Apple's recommendation from:
https://developer.apple.com/documentation/swiftui/migrating-to-new-navigation-types

[BPerlakiH]

@kelson42, @rgaudin New recordings of loading sequences:

iPad:

ipad_new.mov

---

iPhone:

iphone_new.mov

---

macOS:

mac_os_new.mov

[BPerlakiH]

And this is the loading sequence, when there's already a local ZIM file on iPad:

ipad_with_lib_new.mov

[kelson42]

This is not exactly what we discussed, I will come back to you with a mockup so there is no ambiguity anymore on the requirements.

[kelson42]

For all screens, the "block" logo + buttons should be perfectly centered
For the Splash screen:

• In the place of the 2 buttons, perfectly centered in the middle of the place where the two buttons will appear, write "Loading Application..." and the three points should be printed after each other endlessly to show it is progressing)
  
• One we leave the splash screen, we should have the same but displaying in place "Loading application...": "Loading Data..."
• Then finally there is the moment where we display at this place "Fetching Catalog..."
• Finally, once everything is loaded, then we (migh) display the button like following (in red are spaces to remove):
  

Remarks:

• All of this implies that the spinner disappear. The reason is that it seems there is no proper way to have it already running properly at the splash screen level which then create a look & feel disruption.
• The most important is to not display the buttons before everything is ready
• I would love to have a solution which is perfectly localisable, but I don't find one so I can leave with this strings been always in English.
• If you have an alternative in mind to keep consistency and clear description about what is going one between all the boot process (until the two buttons are displayed), please share it.

[BPerlakiH]

@kelson42 I have updated it. Please have a look:

ipad_seq.mov

[kelson42]

Buttons don't have the proper width and don't display the buttons "in a flash" if at the end you want to display the library.

[BPerlakiH]

By matching the button width with the logo width, in some languages (eg French) the button label can run over that, and will look:

[BPerlakiH]

We can make the logo bigger though...
I will need to dig deeper into this, since hard coding the logo size, isn't a good way either, as for custom apps the logo has a different aspect ratio.

[kelson42]

We can make the logo bigger though...

Yes, this is still too small to my taste. My feeling is that on an iPhone, it should take around half of the screen width.

[kelson42]

@BPerlakiH Don't merge main to the feature branch!