975 improve launch sequence #976

BPerlakiH · 2024-09-12T22:24:14Z

Fixes: #975

In combination with the library loading improvements gives a way better UX:

iphone_sim_loading_fix.mov

codecov-commenter · 2024-09-12T22:34:01Z

Codecov Report

Attention: Patch coverage is 69.81132% with 32 lines in your changes missing coverage. Please review.

Project coverage is 38.16%. Comparing base (b0db47c) to head (9edbacc).

Files with missing lines	Patch %	Lines
App/SplitViewController.swift	11.76%	15 Missing ⚠️
Views/Welcome.swift	75.67%	9 Missing ⚠️
App/CompactViewController.swift	55.55%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
+ Coverage   37.99%   38.16%   +0.16%     
==========================================
  Files         114      114              
  Lines        6472     6517      +45     
==========================================
+ Hits         2459     2487      +28     
- Misses       4013     4030      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rgaudin

Please provide more details about what this does.
AFAIU, we know have a spashscreen with centered kiwix-logo in lieu of a blank screen when starting the app.
I'm not sure what happens during this time but on my very old an slow iphone, it's visible but not noticeable (compared to other apps).

kelson42 · 2024-09-13T09:39:41Z

My remarks:

Please make the visual 50% bigger
Make the splash screen dark-mode compatible (with default OS colorsets)
@rgaudin Please share the link to the official visuals for both dark and light modse
The logo should be displayed the whole time at the exact same place, and "Loadding... " should be displayed in place of the buttons as long as they are not available.

BPerlakiH · 2024-09-15T09:44:43Z

Please see the updated sequences on all type of devices, we have the combination of portrait / landscape and light / dark modes:

IPHONE

iphone_dark.mov

iphone_light.mov

IPAD

ipad_light_land.mov

ipad_dark_land.mov

ipad_dark_port.mov

ipad_light_port.mov

MAC

mac_os_light.mov

mac_os_dark.mov

BPerlakiH · 2024-09-15T09:46:48Z

The logo should be displayed the whole time at the exact same place, and "Loadding... " should be displayed in place of the buttons as long as they are not available.

This is not fully possible on iPad landscape mode:

We have a slight movement of the logo from the splash/landing screen to the loading view on iPad, due to the fact that the welcome screen is shifted by the side navigation panel. Here is a comparison of the "welcome screen" with collapsed / expanded navigation bar:

BPerlakiH · 2024-09-15T09:51:50Z

Note: on macOS the launch/splash screen is not supported, so we only have the loading sequence next to the side navigation panel.

BPerlakiH · 2024-09-17T20:50:45Z

Moved it to draft, please do not merge yet, as the custom app side of this needs to be solved first!

BPerlakiH · 2024-09-17T21:29:00Z

Looks OK now, I've tested with the DWDS app.

kelson42 · 2024-09-18T03:15:43Z

I guess we need real logo now.

BPerlakiH · 2024-09-29T12:38:20Z

App/App_macOS.swift

@@ -110,7 +110,7 @@ struct RootView: View {
 private let tabCloses = NotificationCenter.default.publisher(for: NSWindow.willCloseNotification)

 var body: some View {
- NavigationView {
+ NavigationSplitView {


In accordance to Apple's recommendation from:
https://developer.apple.com/documentation/swiftui/migrating-to-new-navigation-types

BPerlakiH added the iOS label Sep 12, 2024

BPerlakiH requested review from rgaudin and kelson42 September 12, 2024 22:24

BPerlakiH linked an issue Sep 12, 2024 that may be closed by this pull request

Improve launch sequence #975

Open

BPerlakiH temporarily deployed to internal September 12, 2024 22:24 — with GitHub Actions Inactive

rgaudin previously approved these changes Sep 13, 2024

View reviewed changes

BPerlakiH force-pushed the 975-improve-iphone-launch-sequence branch from 3b6c4b2 to 02692ac Compare September 14, 2024 18:38

BPerlakiH temporarily deployed to internal September 14, 2024 18:38 — with GitHub Actions Inactive

BPerlakiH dismissed rgaudin’s stale review via d7b0e7c September 14, 2024 21:47

BPerlakiH temporarily deployed to internal September 14, 2024 21:47 — with GitHub Actions Inactive

BPerlakiH temporarily deployed to internal September 15, 2024 09:19 — with GitHub Actions Inactive

BPerlakiH requested a review from rgaudin September 15, 2024 09:54

BPerlakiH added enhancement macOS labels Sep 15, 2024

BPerlakiH added this to the 3.6.0 milestone Sep 15, 2024

BPerlakiH changed the title ~~975 improve iPhone launch sequence~~ 975 improve launch sequence Sep 15, 2024

BPerlakiH marked this pull request as draft September 17, 2024 20:48

BPerlakiH added the don't merge label Sep 17, 2024

BPerlakiH temporarily deployed to internal September 17, 2024 21:18 — with GitHub Actions Inactive

BPerlakiH marked this pull request as ready for review September 17, 2024 21:29

BPerlakiH removed the don't merge label Sep 17, 2024

kelson42 force-pushed the 975-improve-iphone-launch-sequence branch from 81124df to 2be81f5 Compare September 18, 2024 09:30

BPerlakiH added 16 commits September 29, 2024 11:58

Centered logo loading

50db7ca

Loading and LogoViews

e03bb88

Clean up assets, align welcome screen

ea88174

exclude splash from macOS

0d731ce

Move Kiwix specific storyboard to separate folder

93bd3da

Revert the naming to common welcomeLogo

6fbdfba

Replace image, fix image resize

32e4e93

Add SplashScreen

1e0c47c

Handle loading state for iPhone

a529ae8

Fixlint

5816dc8

Centered logo loading

feea6d2

Clean up assets, align welcome screen

306c1e2

Move Kiwix specific storyboard to separate folder

7010bda

Revert the naming to common welcomeLogo

c939018

Replace image, fix image resize

b2ed0e5

Revert safeArea for webview

5c83797

BPerlakiH force-pushed the 975-improve-iphone-launch-sequence branch from 84759a2 to 5c83797 Compare September 29, 2024 10:08

BPerlakiH temporarily deployed to internal September 29, 2024 10:08 — with GitHub Actions Inactive

Update to NavigationSplitView for macOS

b127452

BPerlakiH temporarily deployed to internal September 29, 2024 12:37 — with GitHub Actions Inactive

BPerlakiH commented Sep 29, 2024

View reviewed changes

Change to one loader, and Fetching Catalog text

0009ba4

BPerlakiH temporarily deployed to internal September 29, 2024 12:47 — with GitHub Actions Inactive

Revert

3de4747

BPerlakiH temporarily deployed to internal September 29, 2024 17:58 — with GitHub Actions Inactive

Fixup

3bcf2f2

BPerlakiH temporarily deployed to internal September 29, 2024 17:59 — with GitHub Actions Inactive

BPerlakiH added 2 commits September 29, 2024 21:49

Start with collapsed state for iPad/macOS

900b4fa

Hide tab for iPad on loading, when there's no local ZIM files

9edbacc

BPerlakiH deployed to internal September 29, 2024 22:04 — with GitHub Actions Active

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

975 improve launch sequence #976

975 improve launch sequence #976

BPerlakiH commented Sep 12, 2024

codecov-commenter commented Sep 12, 2024 •

edited

Loading

rgaudin left a comment

kelson42 commented Sep 13, 2024

BPerlakiH commented Sep 15, 2024

BPerlakiH commented Sep 15, 2024 •

edited

Loading

BPerlakiH commented Sep 15, 2024 •

edited

Loading

BPerlakiH commented Sep 17, 2024 •

edited

Loading

BPerlakiH commented Sep 17, 2024

kelson42 commented Sep 18, 2024

BPerlakiH Sep 29, 2024

975 improve launch sequence #976

Are you sure you want to change the base?

975 improve launch sequence #976

Conversation

BPerlakiH commented Sep 12, 2024

codecov-commenter commented Sep 12, 2024 • edited Loading

Codecov Report

rgaudin left a comment

Choose a reason for hiding this comment

kelson42 commented Sep 13, 2024

BPerlakiH commented Sep 15, 2024

IPHONE

IPAD

MAC

BPerlakiH commented Sep 15, 2024 • edited Loading

BPerlakiH commented Sep 15, 2024 • edited Loading

BPerlakiH commented Sep 17, 2024 • edited Loading

BPerlakiH commented Sep 17, 2024

kelson42 commented Sep 18, 2024

BPerlakiH Sep 29, 2024

Choose a reason for hiding this comment

codecov-commenter commented Sep 12, 2024 •

edited

Loading

BPerlakiH commented Sep 15, 2024 •

edited

Loading

BPerlakiH commented Sep 15, 2024 •

edited

Loading

BPerlakiH commented Sep 17, 2024 •

edited

Loading