Fixed the fullscreen keyboard shortcut #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Qt::Key_F11` and `QKeySequence::FullScreen` are of different enum types (`Qt::Key` and `QKeySequence::StandardKey`, respectively) with overlapping value ranges. Using a standard integral type (int, unsigned, long, etc) as a common type for them results in the type information being lost and an ensuing impossibility to take advantage of overloaded constructors of `QKeySequence`. The simple fix is to use `QKeySequence` as the common type of the conditional expression.
kelson42
force-pushed
the
fullscreen_keysequence_fix
branch
from
bc70550 to
1ccfcad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1067 (by fixing the bug introduced by #1068).