Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes toggle reading list shortcut to Ctrl+B #1090

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

vinurk
Copy link
Contributor

@vinurk vinurk commented Apr 15, 2024

Fixes #1088
Changes shortcut to toggle reading shortcut from Ctrl+Shift+2 to Ctrl+B

Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make your PR consist of a single commit and we will merge it.

@vinurk
Copy link
Contributor Author

vinurk commented Apr 16, 2024

@veloman-yunkan
So, do i close this PR and make a new one with a single commit?

@veloman-yunkan
Copy link
Collaborator

No, just rewrite the history of the branch on which this PR is based.

@vinurk vinurk force-pushed the fix/reading-list-shortcut branch from 1c6f8ff to 8184de6 Compare April 16, 2024 19:38
@vinurk vinurk force-pushed the fix/reading-list-shortcut branch from 8184de6 to 0e5ea8b Compare April 16, 2024 19:41
@vinurk
Copy link
Contributor Author

vinurk commented Apr 16, 2024

Done

@kelson42 kelson42 merged commit 07171ba into kiwix:main Apr 18, 2024
4 checks passed
@vinurk vinurk deleted the fix/reading-list-shortcut branch April 18, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current Reading-list/Bookmark keyboard shortcut seems unappropriate
3 participants