Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window position and size is remembered #1126

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ShaopengLin
Copy link
Collaborator

Fix #837

Changes:

  • Stores window size and position on close.
  • Restores on startup.

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
Position and size of the window is saved and restored on startup.
@ShaopengLin
Copy link
Collaborator Author

@kelson42 after a bit of digging I still feel the Qt's handling of this is appropriate. If possible we can have people with other Linux Window Managers test this behavior.

@kelson42
Copy link
Collaborator

@ShaopengLin Thank you. I tested on Ubuntu (so with Gnome Window Manager) and it does the job. I'm sure we have a few edge corners. But at this stage, I believe we should focus on the most usual use cases. If someone comes now or later with an edge case, then we will treat.
@veloman-yunkan To me, good to review.

@kelson42 kelson42 merged commit a4194ce into main Jun 11, 2024
4 checks passed
@kelson42 kelson42 deleted the Issue#837-remember-window-size-and-position branch June 11, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window size and position should be remembered
3 participants