Fix network share launch popup #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgourdas Please change the message to "Kiwix has been launched from a network drive. This is known to cause compatibility issues with the browsing sandboxing. As a result, the sandbox will be disabled. Do you want to continue?" For the rest fine to me, @veloman-yunkan ready to code review. |
sgourdas
force-pushed
the
feature/network-popup
branch
from
fda9d3c to
bb35589
Compare
sgourdas
force-pushed
the
feature/network-popup
branch
from
bb35589 to
b3ac669
Compare
veloman-yunkan
approved these changes
Sep 23, 2024
kelson42
force-pushed
the
feature/network-popup
branch
from
b3ac669 to
10f3f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the faulty implementation of the popup asking the user if he wants to use the app with no sandbox, when launched from a Windows network share.
Now, in such case, the sandbox will be disabled automatically, the app will start and then prompt the user if he wants to proceed acknowledging the fact.
Fixes #885