-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oracular to the build matrix #1289
Conversation
fc10651
to
e80d0d9
Compare
@adamlamar Indeed having a CI also with cutting edge Qt would be helpful |
@adamlamar If you rebase and rerun, this should work now |
40a74bb
to
bd73d0c
Compare
@kelson42 There is a Qt bug that prevents compiling with Of the Ubuntus, Oracular has the newer g++ while the others don't. I added a small amount of handling for Qt6.6 that ignores the I also submitted an Ubuntu bug to hopefully get it fixed in future package updates. |
bd73d0c
to
25c1f8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting feedback from @veloman-yunkan to merge. I have also subscribed myself to the two upstream tickets. Looks like the compilation issue with Qt6.6 is already fixed in Qt6.7.
Finally mergin straight as @veloman-yunkan is pretty busy and the PR simple. |
Sounds good, thank you for the merge. The compilation issue is fixed in Qt 6.6.3, but the ubuntu team just happened to package Qt 6.6.2 and did not yet pull in the fix through another path. |
Ubuntu Noble comes with Qt 6.4. Oracular (24.10) comes with Qt 6.6. Creating this PR to test out the CI for oracular to see if we can get the additional Qt version coverage.