Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oracular to the build matrix #1289

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Add oracular to the build matrix #1289

merged 1 commit into from
Dec 19, 2024

Conversation

adamlamar
Copy link
Collaborator

Ubuntu Noble comes with Qt 6.4. Oracular (24.10) comes with Qt 6.6. Creating this PR to test out the CI for oracular to see if we can get the additional Qt version coverage.

@kelson42
Copy link
Collaborator

@adamlamar Indeed having a CI also with cutting edge Qt would be helpful

@kelson42
Copy link
Collaborator

@adamlamar If you rebase and rerun, this should work now

@kelson42 kelson42 self-requested a review December 18, 2024 04:54
@adamlamar adamlamar force-pushed the oracular-qt6-ci branch 2 times, most recently from 40a74bb to bd73d0c Compare December 18, 2024 19:24
@adamlamar
Copy link
Collaborator Author

@kelson42 There is a Qt bug that prevents compiling with -Werror on newer versions of g++ (13.3 is permissive of the <void> template constructor, 14.2 is not). The bug was part of many Qt releases and was fixed early this year.

Of the Ubuntus, Oracular has the newer g++ while the others don't. I added a small amount of handling for Qt6.6 that ignores the template-id-cdtor error. Since the warning template-id-cdtor is new in g++ 14.2, I can't simply apply the ignore flag on older Ubuntus because g++ complains of an unrecognized warning flag and exits.

I also submitted an Ubuntu bug to hopefully get it fixed in future package updates.

@adamlamar adamlamar marked this pull request as ready for review December 18, 2024 22:31
@kelson42 kelson42 added this to the 2.4.1 milestone Dec 19, 2024
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting feedback from @veloman-yunkan to merge. I have also subscribed myself to the two upstream tickets. Looks like the compilation issue with Qt6.6 is already fixed in Qt6.7.

@kelson42
Copy link
Collaborator

Finally mergin straight as @veloman-yunkan is pretty busy and the PR simple.

@kelson42 kelson42 merged commit 9ecb114 into main Dec 19, 2024
8 checks passed
@kelson42 kelson42 deleted the oracular-qt6-ci branch December 19, 2024 13:04
@adamlamar
Copy link
Collaborator Author

Sounds good, thank you for the merge. The compilation issue is fixed in Qt 6.6.3, but the ubuntu team just happened to package Qt 6.6.2 and did not yet pull in the fix through another path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants