fix-issue-1200 #1341
fix-issue-1200 #1341
Conversation
|
@i-am-space Thanks for the PR! As a reviewer the biggest challenge for me is understanding the problem being solved. The ticket barely describes the issue, extensively focusing on possible solutions instead. As far as I can tell there are two separate issues. If possible, please decompose your PR into two separate commits (fixing one issue at a time) and provide a clear description of the problem being addressed in the commit messages. |
|
@veloman-yunkan the discussion on the feature required is in the comment mentioned in that ticket. I have expanded it in the ticket. |
|
@veloman-yunkan I'm still just fixing a singular issue mentioned in the ticket, where the search bar flickers when you type into it instead of updating live without closing and opening. Apologies for the lack of detail in the commit messages. |
|
@i-am-space I don't believe the search bar was flickering in the current application? The flickering was only a byproduct of one of the solutions that was trying to let suggestions click through, and was not introduced in the PR. Do you have a video of current application behavior? Maybe I am out of date and new changes broke the prior behavior. |
|
I see it now (after pulling my linux laptop from the dust), flickers still happen from time to time. @i-am-space @veloman-yunkan It would be better to keep them in two separate issues. The click-through is a lot more difficult than fixing this flicker and is not directly related. Please create a new issue if you guys agree. |
Then please update the title and description of the PR and the commit message appropriately. |
Fixes part of error #1200, where the search bar flickered when typed into. Search bar no longer flickers when you continue to update the input field in real-time.