Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tab title ellipsis (...) #457

Closed
wants to merge 1 commit into from
Closed

Conversation

jetownfeve21
Copy link
Contributor

I don't find a way to apply a fade out effect when the title is too long to fit in the tab, I just succeed to remove the 3 dots ellipsis but even this solution isn't great :
It uses the fontMetrics().elidedText(QString text, Qt::ElideRight, int width) method to get the elided string, if the string has the ellipsis '...', it removes it. But this method has an int width parameter that represent the space in pixel for the text, I don't find a proper way to have it for a tab, so it's hard coded now, which is bad.

Without the fade out effect, the result looks more like a bug :
image

What we have currently:
image

#358

@kelson42
Copy link
Collaborator

@jetownfeve21 You should not apply a fade-out effect when the title is too long IMO. You should apply a CSS which always apply at the right of the tab and if the title is too long it will have a user visible impact.

@stale
Copy link

stale bot commented Jun 4, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jun 4, 2020
@kelson42
Copy link
Collaborator

Closing this PR as so far we don't know how to handle this.

@kelson42 kelson42 closed this Jun 30, 2020
@kelson42 kelson42 deleted the tab-ellipsis-style branch April 16, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants