Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Back & Forward button alignment for -reverse launch #721

Merged
merged 7 commits into from
Nov 15, 2021
Merged

Conversation

juuz0
Copy link
Collaborator

@juuz0 juuz0 commented Nov 12, 2021

Fixes #595

@juuz0 juuz0 requested review from kelson42 and mgautierfr and removed request for kelson42 November 12, 2021 19:35
@kelson42
Copy link
Collaborator

@juuz0 Actually I'm not really sure about how to test this as there is no settings to change UI language. Any hint on your side?

@juuz0
Copy link
Collaborator Author

juuz0 commented Nov 13, 2021

@kelson42 yes, start kiwix desktop from Terminal as
kiwix-desktop -reverse

@kelson42
Copy link
Collaborator

@juuz0 I have, I hope so, improved a bit the situation on the top of your commit. What do you think about it?

@juuz0
Copy link
Collaborator Author

juuz0 commented Nov 14, 2021

@kelson42 LGTM!

@kelson42
Copy link
Collaborator

@mgautierfr Looks good to you too?

Copy link
Member

@mgautierfr mgautierfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@kelson42 kelson42 merged commit 77d452e into master Nov 15, 2021
@kelson42 kelson42 deleted the issue595 branch November 15, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong order of Back / Forward buttons in right-to-left layout
3 participants