Add server IP Chooser

[juuz0]

Fixes #322
Fixes #726
Needs kiwix/libkiwix#622

[kelson42]

@juuz0 Thank you, I will give a check.

[juuz0]

Updated for latest changes in kiwix/libkiwix#622
Good for a check now

[kelson42]

@juuz0 It does not compile for me:

$ make
g++ -c -pipe -std=c++11 -I/usr/local/include/ -I/usr/local/include -I/usr/include/x86_64-linux-gnu -I/usr/include/p11-kit-1 -O2 -Wall -W -D_REENTRANT -fPIC -DVERSION=2.0.5 -DQT_DEPRECATED_WARNINGS -DQT_NO_DEBUG -DQT_WEBENGINEWIDGETS_LIB -DQT_WEBENGINECORE_LIB -DQT_QUICK_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_WEBCHANNEL_LIB -DQT_QML_LIB -DQT_NETWORK_LIB -DQT_POSITIONING_LIB -DQT_CORE_LIB -I. -Isubprojects/QtSingleApplication/src -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWebEngineWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtWebEngineCore -isystem /usr/include/x86_64-linux-gnu/qt5/QtQuick -isystem /usr/include/x86_64-linux-gnu/qt5/QtPrintSupport -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtWebChannel -isystem /usr/include/x86_64-linux-gnu/qt5/QtQml -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtPositioning -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o contenttypefilter.o src/contenttypefilter.cpp
In file included from src/contenttypefilter.cpp:2:
src/kiwixapp.h:142:21: error: cannot declare field ‘KiwixApp::m_nameMapper’ to be of abstract type ‘KiwixApp::NameMapperProxy’
  142 |     NameMapperProxy m_nameMapper;
      |                     ^~~~~~~~~~~~
src/kiwixapp.h:110:9: note:   because the following virtual functions are pure within ‘KiwixApp::NameMapperProxy’:
  110 |   class NameMapperProxy : public kiwix::NameMapper {
      |         ^~~~~~~~~~~~~~~
In file included from src/kiwixapp.h:18,
                 from src/contenttypefilter.cpp:2:
/usr/local/include/kiwix/name_mapper.h:36:25: note: 	‘virtual std::string kiwix::NameMapper::getNameForId(const string&) const’
   36 |     virtual std::string getNameForId(const std::string& id) const = 0;
      |                         ^~~~~~~~~~~~
/usr/local/include/kiwix/name_mapper.h:37:25: note: 	‘virtual std::string kiwix::NameMapper::getIdForName(const string&) const’
   37 |     virtual std::string getIdForName(const std::string& name) const = 0;
      |                         ^~~~~~~~~~~~
make: *** [Makefile:1017: contenttypefilter.o] Error 1

[juuz0]

@kelson42 because of changes in #732
Rebased now, should work

[kelson42]

It compiles now, but I have a dubious warning:

src/settingsview.cpp: In member function ‘void SettingsView::init(int, int, const QString&)’:
src/settingsview.cpp:27:29: warning: unused parameter ‘port’ [-Wunused-parameter]
   27 | void SettingsView::init(int port, int zoomPercent, const QString &dir)
      |                         ~~~~^~~~

Otherwise looks pretty good:

• One this is started, the inputtext should looks like before: no-border, read-only
• The port input text should be for numbers only and only allowed beetween 0 and 65535
• IPs should be sorted: 0.0.0.0 first, then 127.0.0.1, then all others sorted numerically
• Chosen IP and port should be saved, so if the server is restarted, thenit restarts with the same configuration.

[kelson42]

Looks almost perfect, but needs a bit of beautiful.

[juuz0]

@kelson42 I agree on the beauty, haha. Will do them changes

[juuz0]

Updated @kelson42
Have still kept borders (although decreased size and used light-grey colour like in the invision designs) because without them it was looking weird. Let me know if they have to be removed :)
Followed all other points, I think ✔️

[kelson42]

Few things left:

• Default port should be 8080
• 99999 input should not be possible at port number. Only values from 1 through 65535 are authorized.

[juuz0]

Both done

[kelson42]

Well done

[kelson42]

@mgautierfr Can you please have a look to the code?

[kelson42]

@juuz0 I have rebased and hopefuly, now that kiwix/libkiwix#622 has been merged, the CI will pass.

But I have remarked a small glitch:

Why in the selectbox, we have an empty entry, or at least a white margin, at the bottom of the IP list?

[juuz0]

@kelson42 was an issue with padding, I removed the padding from there and decreased the Port Edit box's to 2px.

[kelson42]

@mgautierfr We really need to move ahead with this PR, please review it quickly.

[mgautierfr]

Only values from 1 through 65535 are authorized.

I wonder if we should go even further and prevent port < 1024.
Those ports are "Well-known ports" and most of the time (on linux at least), the user needs to be root to use them. We probably don't want to use them. (See https://en.wikipedia.org/wiki/List_of_TCP_and_UDP_port_numbers)

[kelson42]

@mgautierfr Not sure about that, port 80 is legit for example. I would avoid that discussion for the moment or at least pospone it in an other ticket.

[mgautierfr]

port 80 is legit for a "real" server. Something running as a daemon and probably with some monitoring (and on linux you need root access)
I don't think it is the use case of kiwix-serve through kiwix-desktop. But we can postpone yes.

[mgautierfr]

Look good to me. @juuz0 Please rebase/fixup before we merge.

[kelson42]

@juuz0 Thx, great to see this PR finally merged and working so well!

[juuz0]

Yay! :D