set zoom factor after page has finished loading #774
Conversation
|
I couldn't get a good reason on why that was happening (it didnt happen, if the search bar article was opened in a different tab) but this looks like the culprit, known bug : |
|
It seems we can not avoid this zoom changing problem because of https://bugreports.qt.io/browse/QTBUG-51851 |
There was a problem hiding this comment.
Beside the rezooming bug (upstream) after clicking on a search result, it looks good. @mgautierfr Please make the code review.
|
@juuz0 Would you be able please to make a comment in the code with a link to the upstream ticket to explain why you rezzoom after having loaded the content |
|
@kelson42 Added, rebased |
kelson42
requested review from
veloman-yunkan
and removed request for
mgautierfr
|
@veloman-yunkan @mgautierfr Changing reviewer in an attemos to move forward with this PR :) |
|
@juuz0 Whats up with this PR? |
This fixes the problem of page not getting the correct zoom factor (after accessing an article from searchbar) Now, the zoom factor is set again after page has completely finished loading
Fixes #770