Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide top widget and tabbar in fullscreen #859

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Hide top widget and tabbar in fullscreen #859

merged 1 commit into from
Jul 24, 2022

Conversation

juuz0
Copy link
Collaborator

@juuz0 juuz0 commented Jul 12, 2022

This change hides the topwidget and tabbar when fullscreen shortcut/button is pressed.
If the mouse is taken to the top of screen, they are shown till the time it is there.
Fixes #571

@juuz0 juuz0 requested review from kelson42 and mgautierfr July 12, 2022 11:07
@juuz0 juuz0 mentioned this pull request Jul 12, 2022
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a user perspective, the PR fix the problem the right way.

@kelson42 kelson42 requested a review from veloman-yunkan July 20, 2022 17:56
@kelson42
Copy link
Collaborator

@veloman-yunkan Considering that this PR is already more than a week old that @mgautierfr will be away for a while, could you please review the code of this PR?

src/mainwindow.cpp Outdated Show resolved Hide resolved
@juuz0 juuz0 requested a review from veloman-yunkan July 23, 2022 12:55
src/mainwindow.cpp Outdated Show resolved Hide resolved
@juuz0 juuz0 requested a review from veloman-yunkan July 23, 2022 16:51
src/mainwindow.cpp Outdated Show resolved Hide resolved
src/mainwindow.cpp Show resolved Hide resolved
@juuz0 juuz0 requested a review from veloman-yunkan July 24, 2022 06:29
src/mainwindow.cpp Show resolved Hide resolved
This change hides the topwidget and tabbar when fullscreen shortcut/button is pressed.
If the mouse is taken to the top of screen, they are shown till the time it is there.
@kelson42 kelson42 merged commit 80129ea into master Jul 24, 2022
@kelson42 kelson42 deleted the newFullscreen branch July 24, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix fullscreen if there is no current webview (zim)
3 participants