Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve zim file picker #886

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Improve zim file picker #886

merged 3 commits into from
Sep 22, 2022

Conversation

kelson42
Copy link
Collaborator

No description provided.

@kelson42 kelson42 requested a review from juuz0 September 18, 2022 14:37
@kelson42 kelson42 added this to the 2.4.0 milestone Sep 18, 2022
@juuz0
Copy link
Collaborator

juuz0 commented Sep 22, 2022

LGTM, are split ZIM files only of the type zimaa? (I thought zimab, zimac, etc were also possible).

@kelson42
Copy link
Collaborator Author

Only .zimaa can be open (this is the begin of the zim file).

@kelson42 kelson42 merged commit e847867 into master Sep 22, 2022
@kelson42 kelson42 deleted the improve-zim-file-picker branch September 22, 2022 07:29
@kelson42 kelson42 modified the milestones: 2.4.0, 2.3.1 Nov 26, 2022
mgautierfr added a commit that referenced this pull request Nov 30, 2022
@mgautierfr
New version 2.3.1
7cd4a02 
 * Fix the AppImage packaging. Now published AppImages work correctly on recent
   distrubution (@mgautierfr #905)
 * Improve zim file picker (@kelson42 #886)
 * Do not show ServiceWorker zim file from the remote catalog (@kelson42 #887)
@mgautierfr mgautierfr mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juuz0 juuz0 Awaiting requested review from juuz0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kelson42 @juuz0